Subject: Re: new EtherIP driver for 4.0
To: None <email@example.com>
From: Christos Zoulas <firstname.lastname@example.org>
Date: 11/22/2006 20:02:59
In article <E0100A33-E32E-4729-9521-0D1A3198D918@fnop.net>,
Rui Paulo <email@example.com> wrote:
>On Nov 21, 2006, at 8:50 PM, Hans Rosenfeld wrote:
>> On Tue, Oct 31, 2006 at 03:09:01PM +0000, Rui Paulo wrote:
>>> I took a very skim look and I couldn't find anything obviously wrong.
>>> There are some KNF nits but nothing important.
>> After some brainstorming with Rui I made some (mostly cosmetic)
>> changes to
>> the code to make it conform to KNF rules. I put the latest version in
>> http://headcrashers.org/comp/programs/etherip.tar.gz for others to
>> another look at it.
>Anyone has anything to say ? I plan to commit this soon.
1. The whole thing needs to be passed through unexpand and possibly
the indentation in ethersubr.c is wrong.
3. etherip_ether_aton() -> ether_snprintf(), same as the tap interface.
Go for it.