Subject: Re: user kfilters
To: Sean Boudreau <firstname.lastname@example.org>
From: Jason Thorpe <email@example.com>
Date: 09/28/2006 10:40:31
On Sep 28, 2006, at 9:58 AM, Sean Boudreau wrote:
> There's a couple of issues in kfilter_byname_user():
> - There's no guarantee the slot at the end of the array
> has name == NULL since all slots up to user_kfiltermaxc
> are potentially used.
> - The test against name != 0 should be *name == 0.
> There's also an issue in kfilter_register() in that
> a new slot is always added to the array: deregistered
> slots are not reused.
> The follwing uses a NULL name to indicate a deregistered
> user filter and not the end of the array. It also reuses
> Any comments before I commit?
Looks cool to me!