Subject: Re: sk(4) interrupt moderation timing fix, and sysctl support
To: Jason Thorpe <email@example.com>
From: Jeff Rizzo <firstname.lastname@example.org>
Date: 11/24/2005 09:49:39
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
Content-Type: text/plain; charset=ISO-8859-1
Jason Thorpe wrote:
> On Nov 23, 2005, at 8:10 PM, Jeff Rizzo wrote:
>> 1. Should I bother supporting a per-board value for the interrupt
>> timer? In this patch, it's global, and only takes effect when
>> is called. (ifconfig down/up is a good way to trigger this)
> Seems like it should be per-instance rather than global, especially
> if different revisions of the chip need to have different values.
Well, the global value is made chip-specific before being applied to the
actual board, but I'll put together a per-instance version anyway; I
think that's probably best.
>> 2. if_bge.c notes that the sysctl stuff will need to be made dynamic to
>> support LKM loading - should I bother with this now, or take it up
> Burn that bridge later.
OK, thanks for the feedback.
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----