Subject: Re: some sack fixes
To: Jonathan Stone <jonathan@dsg.stanford.edu>
From: Kentaro A. Kurahone <kurahone@sigusr1.org>
List: tech-net
Date: 03/17/2005 07:57:30
--+QahgC5+KEYLbs62
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 15, 2005 at 01:12:22PM -0800, Jonathan Stone wrote:
> Also: it looks to me like FreeBSD sys/netinet/tcp_sack.c revision
> 1.8->1.9 (check for receiver sending a SACK block outside the window)
> would be useful. The limits (both per-connection and global) in
> FreeBSD's tcp_sack.c rev 1.9->1.10 sound like they're worth having.
> I also wonder about 1.7->1.8, although (see my first question!)
> maybe our tailq means you already eliminated those usages?

I went and ported over the changes that we were missing, I'd appreciate
some feedback/review before I go and check it in. (Test rig is at work so
it's kind of hard to test extensively right now.)

Diff: http://www.sigusr1.org/~kurahone/dump/tcp-sack-pullupsfreebsd.diff

--=20
Kentaro A. Kurahone
SIGUSR1 Research and Development

--+QahgC5+KEYLbs62
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (FreeBSD)

iQIVAwUBQjk4aGfp+SLSG+tuAQJXXA/7BlTaLwHiNx+ifhF9T6WkeZ0bHzYK8dTI
PrGK1r2/392SyrWVK/bK+Tqy9KuyJf15laNSigDCH9jyCyIRPsVZ0/VWLaJ4/spF
7hLsmMmXBcxhLqV6pZ/mqNLi9lc20qYN1/+q7svoL4P3PHhJ3B58QlOaezqBUv6l
URpNXq/DJ/20qCLf2TVwCweh5Wf0pF4HjjZ0Ab/VsKMlMvYEKgMD5cLQHYo9kTDF
bi9HMqKrEiVObiTvOQhGi+8hqi3bxv9YHTtovJJ6kzTAgMolWomIbwiXTmUPsLoQ
w33f6KZoff3Xnpy+0kTStq/FxfMUbWjitWDhoNJXzRVAOlDHR352+iswYTocCS43
Z9BhYTi8Bpg0i3FRJ6U7G79BBSyxwY08CC3ibC0dGID5OnI5+YCuYbTHKWH+VViR
gVMSyhRNXzP4XVeWHAYi/21EG5BFYTPFg32VPb4SQ3Ttj6x9QO1N8d4O4U0ZmQ8M
Fw2m8Kev5zX2ZvZe+dHqbT8SkRblRkw5oIGoUYLHTbo9cSa0s3d6zy0DFzB3pBNv
SQzvtGtGq5me6dA58q/BIG6hAwOX7mksE/4K7xhUgE3MonOWbLpXUc4y3JqJVCst
RaNvTDiO/EbqYoHyWPkT5YarGWDzSUYfz11F0YDLlyUG33G5ycHly6ihejGFVDOt
H9AsSet1ATc=
=5L1C
-----END PGP SIGNATURE-----

--+QahgC5+KEYLbs62--