Subject: Re: tcp/udp vector h/w checksum
To: YAMAMOTO Takashi <firstname.lastname@example.org>
From: Jonathan Stone <email@example.com>
Date: 02/05/2005 12:34:13
In message <firstname.lastname@example.org>,
YAMAMOTO Takashi writes:
>bge doesn't have to set M_CSUM_NO_PSEUDOHDR in if_csum_flags_tx.
>what's a problem?
D'oh! If there are separate flag spaces for Tx and Rx, then the patch
isn't actually wrong. <slap head> That's what I get for replying
before my first coffee of the day; very sorry.
If we also add an XXX comment to sys/sys/mbuf.h, warning that the
flags have different interpretation in different if_csum_flags_rx
context versus if_csum_flags_tx context, I'd be happier.
I still don't like the precedent it sets, and I think it'd be cleaner
to allocate a separate mask bit (0x40000000?); but it's not a big deal.