--Apple-Mail-22--62437274
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII; format=flowed


On May 21, 2004, at 12:08 PM, Jonathan Stone wrote:

> The following patch introduces a new socket-append function in
> sys/kern/uipc_socket2.c, which will atomically deliver either all of a
> chain of records to a socket so_rcv buffer; or none of the chain.

This patch looks OK to me.  Are you going to do one for the KAME code, 
too, or just fast-ipsec?

> The patch changes the usual RFC-2367 semantics: responses to DUMP
> requests are now unicast to just the socket requesting the dump.
> Moreover, the stream of DUMP messages is deliveered via the new
> ``all-or-nothing'' implementation.

I think unicast for DUMP is fine.  It seems so pointless for DUMP to be 
any other way.

> I have verified that the patch works for dumping 8192 SPD entries.
> Its also markedly faster than the sysctl() version: 1.28 seconds on an
> old P3 laptop, vs 8.82 for the sysctl()-based version.

Faster is good! :-)

         -- Jason R. Thorpe <thorpej@wasabisystems.com>


--Apple-Mail-22--62437274
content-type: application/pgp-signature; x-mac-type=70674453;
	name=PGP.sig
content-description: This is a digitally signed message part
content-disposition: inline; filename=PGP.sig
content-transfer-encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (Darwin)

iD8DBQFAtTsBOpVKkaBm8XkRAhCbAJ4kg7PvI1eifwf4ClZzE5VRINPbFwCggC/0
PjdJMQUlhW6JYzf2HJDpJXs=
=+vPX
-----END PGP SIGNATURE-----

--Apple-Mail-22--62437274--