Subject: Re: kern/25368: crash after SADB_X_SPDFLUSH
To: None <itojun@netbsd.org>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: tech-net
Date: 05/10/2004 18:14:14
hi,

is it ok to commit the following workaround for now?

btw, per-pcb policies are marked as DEAD but no one check it.
is it intended?
i couldn't find any policy API documentation which tells
how SADB_X_SPDDELETE2 and SADB_X_SPDFLUSH should or shouldn't
affect per-pcb policies and how policy ids should be used.

YAMAMOTO Takashi


Index: key.c
===================================================================
--- key.c	(revision 679)
+++ key.c	(working copy)
@@ -7746,9 +7746,10 @@ key_sp_unlink(sp)
 {
 
 	/* remove from SP index */
-	if (__LIST_CHAINED(sp))
+	if (__LIST_CHAINED(sp)) {
 		LIST_REMOVE(sp, chain);
-	key_freesp(sp);
+		key_freesp(sp);
+	}
 }
 
 /* XXX too much? */