Subject: Re: kern/21696 again
To: None <firstname.lastname@example.org>
From: Manuel Bouyer <email@example.com>
Date: 07/09/2003 23:18:44
On Sat, Jun 28, 2003 at 06:52:11PM +0200, Manuel Bouyer wrote:
> commit back (a bit late, I can't say otherwise) about the problem I explained
> in kern/21696 (in a nutshell: nfsrv_commit() may call VOP_FSYNC() with
> range past the end of file because of unchecked arguments, triggering
> a diagnostic panic later). Based on comments from YAMAMOTO Takashi and
> Chuck Silvers here is a new patch, which makes the code return OK to the client
> without doing the flush when offset is past the end of file.
> The rationale for this (pointed out by Chuck) is that because of races
> between the clients, we can expect to have commit requests past the end
> of files. This is also why I didn't add messages logs for this, as
> suggested by Christos Zoulas.
> If noone object, I'll commit this in a few days.
FYI, I commited this (better late than never :).
Manuel Bouyer <firstname.lastname@example.org>
NetBSD: 24 ans d'experience feront toujours la difference