Subject: Re: ALTQ and pppoe
To: None <email@example.com>
From: Kenjiro Cho <firstname.lastname@example.org>
Date: 07/09/2003 21:13:05
Martin Husemann wrote:
> > Is it possible for you to test the following patch?
> Not easily for me right now, but can you explain what you are trying
> to do? In the case you modified (ignoring the cisco hdlc mode for now)
> we will not be able to send any payload packets, since no NCP has negotiated
> a connection (yet). Since the negotiation itself does not use the ALTQ
> controlled queues, I don't think enabling ALTQ would interfere with that.
Andrzej's altqstat(1) shows ALTQ fails to dequeue packets from pppoe0
even when packets are in the queue.
It seems to me that sppp_dequeue() returns NULL, and the only
condition I found in the code path is
(sppp_ncp_check(sp) || (sp->pp_flags & PP_CISCO) != 0)
I don't have PPPoE and can't test it by myself.