Subject: Re: ALTQ and pppoe
To: None <aszeszo@o2.pl>
From: Kenjiro Cho <kjc@csl.sony.co.jp>
List: tech-net
Date: 07/09/2003 20:08:06
Andrzej Szeszo wrote:
> I'm starting altqd and then trying to ping some remote machine.
> altqstat shows:
> 
> # altqstat
> altqstat: fifoq on interface pppoe0
>  q_len:9 q_limit:50 period:0
>  xmit:0 pkts (0 bytes) drop:0 pkts (0 bytes)
>  throughput: 0bps
>  q_len:35 q_limit:50 period:0
>  xmit:0 pkts (0 bytes) drop:0 pkts (0 bytes)
>  throughput: 0bps
>  q_len:50 q_limit:50 period:0
>  xmit:0 pkts (0 bytes) drop:20 pkts (916 bytes)
>  throughput: 0bps

It shows that packets are successfully queued but never dequeued.
Is it possible for you to test the following patch?

-Kenjiro


Index: if_spppsubr.c
===================================================================
RCS file: /cvsroot/kame/kame/netbsd/sys/net/if_spppsubr.c,v
retrieving revision 1.10
diff -u -r1.10 if_spppsubr.c
--- if_spppsubr.c	23 May 2003 11:44:20 -0000	1.10
+++ if_spppsubr.c	9 Jul 2003 11:00:11 -0000
@@ -1050,7 +1050,11 @@
 	 */
 	IF_DEQUEUE(&sp->pp_cpq, m);
 	if (m == NULL &&
-	    (sppp_ncp_check(sp) || (sp->pp_flags & PP_CISCO) != 0)) {
+	    (sppp_ncp_check(sp) || (sp->pp_flags & PP_CISCO) != 0
+#ifdef ALTQ
+	    || ALTQ_IS_ENABLED(&ifp->if_snd) != 0
+#endif
+		)) {
 		IF_DEQUEUE(&sp->pp_fastq, m);
 		if (m == NULL)
 			IFQ_DEQUEUE(&sp->pp_if.if_snd, m);