Subject: Re: PF for netbsd
To: Manuel Bouyer <bouyer@antioche.lip6.fr>
From: None <itojun@iijlab.net>
List: tech-net
Date: 07/03/2003 20:54:22
	orange.kame.net:~ftp/pub/kame/misc/netbsd-pf-20030703.diff.gz

>> 	new diff is avaialble, this time includes IPsec-with-PF diff.
>As far as I can tell, qname_to_qid() & all aren't dependant from pf but
>rather from altq. Maybe they should be moved to altq instead ?

	kjc will do something about it.

>Also, it seems tagname2tag() & friend is back into pf code, is it
>intentionnal ?

	see conversation w/ darrenr.  anyways it's back in uipc_mbuf2.c.

>Also there should probably be no
>#if NPF > 0
>in non-pf code (ipsec and altq).
>
>And really, I'd prefer to have the struct and functions names for the
>m_tag stuff with another prefix than pf. It makes the code much more readable
>when each subsystem's name is properly prefixed, and really confusing when
>the same prefix is used for different subsystems.

	"tag" is already used for m_tag, so i guess "pftag" is the best name
	i can think of.

itojun