On Tue, Jul 01, 2003 at 04:11:46PM +0900, itojun@iijlab.net wrote:
> 	new diff is avaialble, this time includes IPsec-with-PF diff.
> 	orange.kame.net:~ftp/pub/kame/misc/netbsd-pf-20030701.diff.gz


As far as I can tell, qname_to_qid() & all aren't dependant from pf but
rather from altq. Maybe they should be moved to altq instead ?

Also, it seems tagname2tag() & friend is back into pf code, is it
intentionnal ?

Also there should probably be no
#if NPF > 0
in non-pf code (ipsec and altq).

And really, I'd prefer to have the struct and functions names for the
m_tag stuff with another prefix than pf. It makes the code much more readable
when each subsystem's name is properly prefixed, and really confusing when
the same prefix is used for different subsystems.

--
Manuel Bouyer, LIP6, Universite Paris VI.           Manuel.Bouyer@lip6.fr
     NetBSD: 24 ans d'experience feront toujours la difference
--