Subject: Re: bridge(4) fixes and improvement
To: Manuel Bouyer <>
From: Jason R Thorpe <>
List: tech-net
Date: 03/14/2003 11:11:02
On Fri, Mar 14, 2003 at 06:45:18PM +0100, Manuel Bouyer wrote:

 > I'd like to commit the attached diff. It fixes two bugs I found with
 > bridge(4):
 > - stp isn't initialised when we turn the bridge up; as a result
 >   brconfig bridge0 add if0 add if1 stp if0 stp if1 up
 >   (which is the way of setting up stp in brconfig(8)) doen't work
 >   because the stp state for both interface stays disabled.
 > - in brconfig, setting the if priority doesn't work because of a cut-n-paste
 >   mistake: do_cmd() was called with BRDGSPRI instead of BRDGSIFPRIO.
 > It also adds the a way to change an interface path cost. This is usefull in
 > some cases. For example, you have a backup link which you don't want to be
 > used.
 > Comments, objections ?

Looks great, please check this in!

        -- Jason R. Thorpe <>