Subject: Re: pppoe & mbuf chain
To: YAMAMOTO Takashi <firstname.lastname@example.org>
From: David Laight <email@example.com>
Date: 06/21/2002 17:39:17
On Sat, Jun 22, 2002 at 01:24:24AM +0900, YAMAMOTO Takashi wrote:
> From: David Laight <firstname.lastname@example.org>
> > > + m = m_pullup(m, m->m_len);
> > you want to free the original 'm' which you have carefully
> > lost!
> - if m_pullup fails, it frees "original m".
> - m_freem(0) is safe.
> am i missing something?
Ok maybe I didn't check char m_pullup() does, but every
other pullup() I've seen doesn't.
Also discarding the old data block isn't friendly!
David Laight: email@example.com