Subject: Re: ESP using blowfish doesn't work (on i386)
To: None <email@example.com>
From: None <firstname.lastname@example.org>
Date: 02/27/2002 10:44:22
>> I tried to use ESP with blowfish as its encrypt algorithm,
>> but it doesn't work because i386 asm version of BF_encrypt
>> is prototype-mismatched with C version.
>> applying attached patches (or fixing i386 asm version instead) solve
>> the problem. are this patches right and can i commit?
>The patch is right, the third argument isn't actually used and is there
>just for symmetry with the DES functions AFAICT.
i guess we should have regress/sys/crypto that checks assembly version
as well. any volunteers?
>However, what's with all the gratuitous whitespace and other formatting
>changes in the patch?
because there's one fewer if statement ("if (encrypt)").