Subject: Re: am79900.c tweak
To: None <firstname.lastname@example.org>
From: der Mouse <mouse@Rodents.Montreal.QC.CA>
Date: 07/11/2001 11:37:59
One person has already misunderstood my note about am79900.c.
I was (am) not asking for review of a proposed patch; I'm offering a
suggestion to anyone else who has similar trouble.
I've also been told the patch doesn't apply cleanly, which as I
indicated is no surprise; however, apparently the sentence I added to
indicate where it went in that case wasn't clear enough.
Most briefly, the fix is to add lance_reset(sc) (and return(1), if
absent) to the code that prints "missed packet", which is when
LE_C0_MISS is set in am79900_intr. (In every version of am79900.c I've
examined, there is only one such, and while the printf is conditional
on LEDEBUG, it does serve to indicate the point in question.)
I don't propose to commit it as it stands; if nothing else, I have no
particular reason to think it is innocuous on other chips that use
am79900.c. It does fix a problem I ran into (as described in my first
message); if anyone else has a similar problem, it may be worth
/~\ The ASCII der Mouse
\ / Ribbon Campaign
X Against HTML email@example.com
/ \ Email! 7D C8 61 52 5D E7 2D 39 4E F1 31 3E E8 B3 27 4B