Subject: Re: placement of PFIL_HOOKS filtering points
To: None <firstname.lastname@example.org>
From: Darren Reed <email@example.com>
Date: 11/09/2000 07:29:08
In some email I received from Jason R Thorpe, sie wrote:
> On Wed, Nov 08, 2000 at 11:32:04PM +1100, Darren Reed wrote:
> > Hmm, I'd rather see this patch bump the kernel revision and add the
> > bits you put in the wrapper inside of fr_check with the appropriate
> > #ifdef's. Your patch also would appear to be ignorant of IPv6 at
> > present...
> Yes, I would do that. I omitted that from the patch. I suppose I should
> also present my other change (to pfil_hooks itself) and commit it at the
> same time -- only one kernel bump.
> Re. IPv6 -- I checked -- it didn't appear that anything got swapped for
> the IPv6 case. Did I miss something?
You changed the hook in the pfil setup for both IPv4 and IPv6 to the
wrapper, and then swap bytes for ip_len and ip_off without checking
that it is IPv4.