To: None <firstname.lastname@example.org>
From: Charles M. Hannum <email@example.com>
Date: 01/26/1999 21:23:31
So I'm looking at ipflow_fastforward(), and I think it does more work
than it needs to. To wit:
1) There's no need to check both ipforwarding and ipflow_inuse.
2) There's no need to check the header checksum. In the rare case
where it's incorrect, either: a) we will fail to find a flow and go
through the slow path anyway, or b) it will be dropped by the
destination host. I believe many hardware routers don't do this
3) There's no need to check the IP packet length. Again, in the rare
case where it's incorrect, it will be rejected on the destination
host. Furthermore, truncating the packet may actually reduce
efficiency (e.g. by forcing us to repad a packet to send it out an
Since the whole point of this code is to make the forwarding case
faster, it seems like a good idea to remove as much code as possible.