tech-misc archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

makefiles that still set MKMAN=no

% find src -name 'Make*' -print | xargs grep 'MKMAN[^A-Z{}]*='
src/sys/arch/amiga/stand/bootblock/elf2bb/Makefile:MKMAN=       no
src/sys/arch/arc/stand/boot/Makefile:MKMAN= no          # defined
src/sys/arch/hp700/stand/xxboot/Makefile:MKMAN=         no
src/sys/arch/hpcmips/stand/lcboot/Makefile:MKMAN=       no
src/sys/arch/sbmips/stand/                   no
src/x11/Xserver/Xserver/XalphaNetBSD/Makefile:MKMAN=    no
src/x11/Xserver/Xserver/Xarm32VIDC/Makefile:MKMAN=      no
src/x11/Xserver/Xserver/XdecNetBSD/Makefile:MKMAN=      no
src/x11/Xserver/Xserver/Xmacppc/Makefile:MKMAN= no
src/x11/Xserver/Xserver/Xsun24/Makefile:MKMAN=  no
src/x11/Xserver/Xserver/XsunMono/Makefile:MKMAN=        no

I am not entirely willing to touch these without matching toolchains,
which I don't have right now. (Particularly the Makefile.incs.) So if
those of you who work on these platforms regularly could attend to
these it would be helpful.

The deal is that source makefiles aren't supposed to set MKMAN,
they're supposed to set NOMAN. Otherwise, if someone sets MKMAN=yes on
the command line, or possibly from mk.conf, that takes precedence and
the build breaks.

However, NOMAN has to be set before gets included, or it
fails silently. Almost all the cases I've found and fixed so far have,
unsurprisingly, had first in the file, so setting NOMAN
later on didn't work.

This violates the general rule that should, if present,
come first, so the proper arrangement for these files is

        NOMAN=# defined (must come before

        .include <>

        (other stuff)

as in e.g. src/x11/Xserver/hw/dmx/bin/xdmx/Makefile.

Cheers. :-|

David A. Holland

Home | Main Index | Thread Index | Old Index