Re: ZFS L2ARC on NetBSD-9

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Mon, Apr 19, 2021 at 05:59:39PM +0000, Andrew Parker wrote:
> [...]
> 
> Oops.  I completely misread how the return value of l2arc_write_interval is used so that patch doesn't make any sense.  But adding the printf suggested earlier results in this just after boot:
> 
> 
> [    14.600107] WARNING: ZFS on NetBSD is under development
> [    14.650039] ZFS filesystem version: 5
> [    14.650039] wait 100
> [    15.690043] wait 96
> [    17.840054] wait 0
> 
> The l2arc then seems to hang indefinitely as I never see another l2 feed after the "wait 0" message:


yes, because '0' means "infinity" for cv_timedwait().
This should be changed to make sure at that cv_timedwait() is called with
a timeout value of at last 1, or (maybe better) skip cv_timedwait() if
the value is 0.

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--