Re: [PATCH v4 2/4] Fix alignment when reading core notes

[christos%astron.com@localhost (Christos Zoulas)]

In article <20191222164104.165346-2-mgorny%gentoo.org@localhost>,
MichaŠ Górny  <mgorny%gentoo.org@localhost> wrote:
>Both desc and note header needs to be aligned.  Therefore, we need
>to realign after skipping past desc as well.

Should probably be done with a standard alignment macro?

christos

>---
> tests/lib/libc/sys/t_ptrace_wait.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/tests/lib/libc/sys/t_ptrace_wait.c
>b/tests/lib/libc/sys/t_ptrace_wait.c
>index 6fc43572e015..1097a351fd92 100644
>--- a/tests/lib/libc/sys/t_ptrace_wait.c
>+++ b/tests/lib/libc/sys/t_ptrace_wait.c
>@@ -7603,6 +7603,9 @@ static ssize_t core_find_note(const char *core_path,
> 			}
> 
> 			offset += note_hdr.n_descsz;
>+			/* fix to alignment */
>+			offset = ((offset + core_hdr.p_align - 1)
>+			    / core_hdr.p_align) * core_hdr.p_align;
> 		}
> 	}
> 
>-- 
>2.24.1
>
>