Re: File sharing over virtio-9p

[Valery Ushakov <uwe%stderr.spb.ru@localhost>]

On Thu, Oct 24, 2019 at 13:32:59 +0900, Ryota Ozaki wrote:

> I've prepared complete patches ready to commit:
>   https://www.netbsd.org/~ozaki-r/tweak-MAKEDEV.diff
>   https://www.netbsd.org/~ozaki-r/vio9p.diff
>   https://www.netbsd.org/~ozaki-r/vio9p-configs.diff
>   https://www.netbsd.org/~ozaki-r/mount_9p-cdev.diff

Just a few minor nit-picks:

@@ -60,6 +60,8 @@ usage(void)
[...]
+   fprintf(stderr, "       %s [-s] [-o mntopts] -cu cdevfile mountpoint\n",

Why not [-su] as in the usage just above for the TCP case?


@@ -72,7 +74,7 @@ serverconnect(const char *addr, unsigned short port)
[...]
+	    err(1, "setsockopt(SO_NOSIGPIPE)");

I'd just trim it down to "SO_NOSIGPIPE".

+   	 err(1, "open(%s)", path);

Ditto.  Just make it "%s".


Thanks!

-uwe