tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: [PATCH v3] Include XSTATE note in x86 core dumps

On Tue, 2019-07-16 at 05:23 +1000, matthew green wrote:
> > Introduce a simple COREDUMP_MACHDEP_LWP_NOTES logic to provide machdep
> > API for injecting per-LWP notes into coredumps, and use it to append
> > PT_GETXSTATE note.
> this macro is pretty gross.  these are the problems i see:
> - assumes 'int error'
> - assumes 'struct lwp *l = curlwp'
> - assumes 'name' is something
> - assumes 'ns' is something

It also relies on ELFSIZE being defined in unit using the macro.  Should
I make that into a parameter as well?

Best regards,
Michał Górny

Attachment: signature.asc
Description: This is a digitally signed message part

Home | Main Index | Thread Index | Old Index