tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: [PATCH v3 2/2] Implement PT_GETXSTATE and PT_SETXSTATE



Le 22/06/2019 à 09:38, Michał Górny a écrit :
Hi,

Attached is the next version of unified patch.  I've updated the boolean
logic as requested, and fixed indentations.

Looks good to me. Please don't use ()s when not needed, like

-		memset(&(xstate->xs_fxsave), 0, sizeof(xstate->xs_fxsave));
-		process_s87_to_xmm(&fpu_save->sv_87, &(xstate->xs_fxsave));
+		memset(&xstate->xs_fxsave, 0, sizeof(xstate->xs_fxsave));
+		process_s87_to_xmm(&fpu_save->sv_87, &xstate->xs_fxsave);

but whatever, this is detail


Home | Main Index | Thread Index | Old Index