Re: verbose vflushbuf()

[David Holland <dholland-tech%netbsd.org@localhost>]

On Thu, Aug 09, 2018 at 12:44:28PM +0000, Emmanuel Dreyfus wrote:
 > It seems we have something like a debug message left in 
 > src/sys/kern/vfs_subr.c:vflushbuf()
 > 
 > 	if (dirty) {
 > 		vprint("vflushbuf: dirty", vp);
 > 		goto loop;
 > 	}
 > 
 > It has been there for a while (7 years). Is there a reason 
 > why it remains always enabled? I have a machine that hit 
 > the place in a loop, getting stuck for hours printing
 > messages on the console. If it safe to #ifdef DEBUG this
 > printf?

Probably, but I don't think it's supposed to happen and possibly it
should be a panic:

/*
 * Called with the underlying vnode locked, which should prevent new dirty
 * buffers from being queued.
 */


-- 
David A. Holland
dholland%netbsd.org@localhost