tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Removing dbregs



On 26.07.2018 09:24, Maxime Villard wrote:
> For the record, I ended up with a functional patch [1]. This removes the
> reload of DR6/DR7 on each kernel->user transition, and rather does it
> during context switches, only when dbregs are being used. Tested ATF on
> i386 and amd64, it works.
> 
> Kamil wanted to do extra testing, but basically this patch is close to the
> final version.
> 
> [1] http://m00nbsd.net/garbage/dbregs/dbregs.diff

It looks good to me. I've tested it under load on i386 and amd64 - for
the past 3 days - with no regression observed.

From a style point of view, I would use the ISSET(9)-like API in the
code, instead of manual bit operations.

Attachment: signature.asc
Description: OpenPGP digital signature



Home | Main Index | Thread Index | Old Index