Re: compat work.

[Paul Goyette <paul%whooppee.com@localhost>]

(Adding tech-kern@ to cc)

Such "factoring out" is far beyond my capabilities, especially when we 
get into areas such as the networking code.  There are just too many 
parts of the system which I do not adequately understand.

I can either maintain the current capabilities, warts and all, or I can 
abandon the effort.  There is just too much spaghetti code already, and 
too much "compat_xx" code which is only reachable when built-in.

It would have been much more appreciated if you had done your work on 
the branch, rather than completely invalidating the work I'd already 
done.



On Wed, 14 Mar 2018, Christos Zoulas wrote:

> Please try to factor out the poorly written compat code before you convert
> it to the new world order, otherwise we'll end up with a bigger mess. I did
> that for the swapctl code; it should be much easier now to split the compat
> parts out without ifdefs...
>
> In the switch for the swap_stats "default" handle the compat code
> by passing stuff to a single compat function that is either NULL
> or returns EPASSTHROUGH when it can't handle the syscall. Otherwise
> the function should just return the return value the compat function
> returned.
>
> The idea is to expose as little guts of the compat variables as possible,
> and use function pointers instead of variables...
>
> christos
>
> !DSPAM:5aa9d395212563655414781!

+------------------+--------------------------+----------------------------+
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:          |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
+------------------+--------------------------+----------------------------+