tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: RFC: vlan(4) use pkthdr instead of mtag



Thank you for the comments.

I updated the patch:
https://gist.githubusercontent.com/s-ymgch228/6597cfc4b6f79c6c62fcdf25003acb55/raw/8237c14badb390355613794f5e3dee92431a89d2/vlan_mtag.patch
https://gist.githubusercontent.com/s-ymgch228/6597cfc4b6f79c6c62fcdf25003acb55/raw/7169afbe597f3fb562cdc6afc4ef9caaa04d2542/vlan_mtag.patch.diff

Changes:
 - sys/mbuf.h
  - Add a comment like  /* 1: Used to be VLAN ID */
  - Add line breaks to M_COPYFLAGS
 - if_vlan.c
  - Fix branches
 - if_ether.h
  - Introduce vlan_has_tag and use it in drivers

the comments for the size of pkthdr on LP64 was not updated because
the result that I checked the size using the test code like
"printf("%lu\n", sizeof(struct pkthdr))" was 56 on amd64 after
applying the patch

Regards,
s-yamaguchi@IIJ

-- 
Internet Initiative Japan Inc.

Device Engineering Section,
IoT Platform Development Department,
Network Division,
Technology Unit

Shoichi YAMAGUCHI <s-yamaguchi%iij.ad.jp@localhost>



Home | Main Index | Thread Index | Old Index