Re: veriexec

[Brett Lymn <brett.lymn%baesystems.com@localhost>]

On Tue, Aug 29, 2017 at 10:36:57AM +0800, Paul Goyette wrote:
> On Tue, 29 Aug 2017, Paul Goyette wrote:
> 
> >While looking at Sevan's recent PR, I notice a couple of problems with the 
> >current code.
> >
> >In sys/kern_veriexec.c routine veriexec_file_add(), at line 1072 we 
> >allocate a vfe entry, and initialize the rw_lock contained therein.
> >
> >Then there are some error branches at lines 1082 and 1090 that simply 
> >"goto out" without ever destroying the rw_lock nor free()ing the vfe.
> >
> >(diffs removed, since they were wrong!)
> >
> >Comments or other suggestions?
> 
> On IRC, riastradh@ pointed out that the above diffs are not quite right, 
> since in the success case we need to avoid destroying the rwlock and 
> free()ing the vfe entry.
> 

LGTM.  Thanks.

-- 
Brett Lymn
This email has been sent on behalf of one of the following companies within the BAE Systems Australia group of companies:

    BAE Systems Australia Limited - Australian Company Number 008 423 005
    BAE Systems Australia Defence Pty Limited - Australian Company Number 006 870 846
    BAE Systems Australia Logistics Pty Limited - Australian Company Number 086 228 864

Our registered office is Evans Building, Taranaki Road, Edinburgh Parks,
Edinburgh, South Australia, 5111. If the identity of the sending company is
not clear from the content of this email please contact the sender.

This email and any attachments may contain confidential and legally
privileged information.  If you are not the intended recipient, do not copy or
disclose its content, but please reply to this email immediately and highlight
the error to the sender and then immediately delete the message.