Re: CVS commit: src/sys/dev/scsipi

[mlelstv%serpens.de@localhost (Michael van Elst)]

k-nakahara%iij.ad.jp@localhost (Kengo NAKAHARA) writes:

>Hi,

>Today, I found my environment panic while rebooting. As bisecting, it
>seems the cause is below commit.

Does the following patch help ?

Index: scsipi_base.c
===================================================================
RCS file: /cvsroot/src/sys/dev/scsipi/scsipi_base.c,v
retrieving revision 1.176
diff -p -u -r1.176 scsipi_base.c
--- scsipi_base.c	17 Jun 2017 22:35:50 -0000	1.176
+++ scsipi_base.c	19 Jun 2017 14:14:58 -0000
@@ -2403,7 +2403,7 @@ scsipi_target_detach(struct scsipi_chann
 	device_t tdev;
 	int ctarget, mintarget, maxtarget;
 	int clun, minlun, maxlun;
-	int error;
+	int error = 0;
 
 	if (target == -1) {
 		mintarget = 0;
@@ -2453,7 +2453,7 @@ scsipi_target_detach(struct scsipi_chann
 out:
 	KERNEL_UNLOCK_ONE(curlwp);
 
-	return 0;
+	return error;
 }
 
 /*

Greetings,
-- 
-- 
                                Michael van Elst
Internet: mlelstv%serpens.de@localhost
                                "A potential Snark may lurk in every tree."