On Thu, 15 Jun 2017, Paul Goyette wrote:
While recently working with Nat to get the wsbell(4) device working, I've noticed that both wsdisplay(4) and wsmouse(4) (as well as the new wsbell(4)) have lots of code conditionally compiled based on "NWSMUX0" (which is defined in wsmux.h resulting from the needs-flag inwscons/files.wscons). Does it really make sense to have a kernel with either wsdisplay(4) or wsmouse(4) but _without_ any wsmux(4) devices? It would really make things a lot cleaner if we were able to remove some of this conditional compilation.
I'm a bit surprised that there hasn't yet been any response on this subject. :) Usually when I propose something, it prompts some fairly lively discussion.
Would anyone object if I were to remove all of the "#if NWSMUX > 0" conditionals, and simply require the wsmux code to be included (via files.wscons) whenever any child dev (wsdisplay, wskbd, wsmouse, or wsbell) is configured?
+------------------+--------------------------+----------------------------+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | (Retired) | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com | | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org | +------------------+--------------------------+----------------------------+