Re: if_wm panics on boot

[Tomohiro Kusumi <kusumi.tomohiro%gmail.com@localhost>]

Hi

Now I'm at
$NetBSD: if_wm.c,v 1.495 2017/03/03 07:57:49
but still hits the same assertion located at L6622.

Btw I'm running this on a vm guest.
Haven't looked into any detail of this panic, but is this a race that
no one else is seeing ?

-----
   6616 4b2db683293e (msaitoh   2010-01-14 18:56:02 +0000  6616) static void
   6617 a42d09650a04 (msaitoh   2014-07-23 10:48:16 +0000  6617)
wm_start(struct ifnet *ifp)
   6618 4b2db683293e (msaitoh   2010-01-14 18:56:02 +0000  6618) {
   6619 a42d09650a04 (msaitoh   2014-07-23 10:48:16 +0000  6619)
 struct wm_softc *sc = ifp->if_softc;
   6620 4a99150fe48a (knakahara 2016-05-19 08:27:57 +0000  6620)
 struct wm_txqueue *txq = &sc->sc_queue[0].wmq_txq;
   6621 4b2db683293e (msaitoh   2010-01-14 18:56:02 +0000  6621)
   6622 4237fb09aa71 (knakahara 2016-06-20 08:34:59 +0000  6622)
 KASSERT(ifp->if_extflags & IFEF_START_MPSAFE);  <----------- now here
   6623 4237fb09aa71 (knakahara 2016-06-20 08:34:59 +0000  6623)
   6624 142aff0c9703 (knakahara 2016-12-02 01:48:44 +0000  6624)        /*
   6625 142aff0c9703 (knakahara 2016-12-02 01:48:44 +0000  6625)
  * ifp->if_obytes and ifp->if_omcasts are added in
if_transmit()@if.c.
   6626 142aff0c9703 (knakahara 2016-12-02 01:48:44 +0000  6626)         */
   6627 142aff0c9703 (knakahara 2016-12-02 01:48:44 +0000  6627)
   6628 33a8904ac07a (skrll     2016-06-14 09:07:22 +0000  6628)
 mutex_enter(txq->txq_lock);
   6629 4e1eaa61873d (knakahara 2016-10-28 04:14:13 +0000  6629)
 if (!txq->txq_stopping)
   6630 a42d09650a04 (msaitoh   2014-07-23 10:48:16 +0000  6630)
         wm_start_locked(ifp);
   6631 33a8904ac07a (skrll     2016-06-14 09:07:22 +0000  6631)
 mutex_exit(txq->txq_lock);
   6632 4b2db683293e (msaitoh   2010-01-14 18:56:02 +0000  6632) }


2017-03-03 18:52 GMT+02:00 Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost>:
> Hi,
>
> On 2017/03/04 0:29, Tomohiro Kusumi wrote:
>> Yes, the source says 1.492 which is very recent.
>> I guess I'll just revert to the one that was (safely)working for now.
>>
>> 1.492 2017/03/03 03:33:44 knakahara
>
> Sorry, it is my mistake as you point out. I fix it r1.495 just now.
>
> Could you try the newest wm?
>
>
> Thanks,
>
> --
> //////////////////////////////////////////////////////////////////////
> Internet Initiative Japan Inc.
>
> Device Engineering Section,
> IoT Platform Development Department,
> Network Division,
> Technology Unit
>
> Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost>