tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: x86: move the LAPIC va



On Sat, Oct 15, 2016 at 12:35:39PM +0200, Maxime Villard wrote:
> Le 08/10/2016 à 17:14, Maxime Villard a écrit :
> > The patch is available here [1]. Clearly, I'm not going to commit it now, but
> > if someone here has an opinion about it, or if you think there is something
> > obviously wrong that I missed, feel free to tell me about it.
> > 
> > [1] http://m00nbsd.net/garbage/lapic/
> > 
> 
> (I have updated and simplified the patch)

Please don't use untyped vaddr_t locations with random casts all over
the place, but use or define a struct with the appropiate (volatile) fields.

Joerg


Home | Main Index | Thread Index | Old Index