tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: UVM and the NULL page



In article <29bc17a0-924a-9eb3-ea57-196853642627%m00nbsd.net@localhost>,
Maxime Villard  <max%m00nbsd.net@localhost> wrote:
>Le 31/07/2016 à 15:39, Christos Zoulas a écrit :
>> In article <311df12c-d620-1c09-92f5-72783f3926d9%m00nbsd.net@localhost>,
>> Maxime Villard  <max%m00nbsd.net@localhost> wrote:
>>>
>>> My first proposion did not take care of the sysctl, because I didn't think it
>>> was relevant. My last one does. Here is a patch for it. I believe it is safe
>>> then to remove the va0_disable check in uvm_map.
>>>
>>> 	http://m00nbsd.net/garbage/uvm/execmin.diff
>>>
>>
>> Should we check that va_min == 0 before adding VM_MIN_GUARD?
>>
>
>I told myself I would add this check later, but better it be now. We can do the
>following:
>
>+	if (user_va0_disable && (va_min < VM_MIN_GUARD))
>+		return VM_MIN_GUARD;

I am fine with that diff.

christos



Home | Main Index | Thread Index | Old Index