Re: Adding sc_pid to SCM_CREDS

[Roy Marples <roy%marples.name@localhost>]

On 30/03/2016 16:13, Iain Hibbert wrote:
> On Tue, 29 Mar 2016, Roy Marples wrote:
> 
>> Attached is a patch which adds sc_pid to struct sockcred and correctly
>> fills it out. The old sockcred structure is available as osockcred in
>> compat/sys/socket.h and guarded by COMPAT_70.
>>
>> Everything seems to work ok with old binaries, but would appreciate some
>> extra eyes on the compat code or any suggestion how it could be done better.
> 
> there seems to be some variation in the naming scheme -- eg osockcred, 
> SOCKOCREDSIZE, LOCAL_OCREDS, UNP_WANTOCRED 
> 
> should all this rather be styled cred70 if it is COMPAT_70 ?

That's a fair point.
renamed to struct sockcred70, SOCKCRED70SIZE and
compat70_unp_addsockcred to be more inline with other compat foo.

Keeping LOCAL_OCREDS, SCM_OCREDS and UNP_OWANTCRED because that seems to
be more inline with other compat #defines like these - see net/route.h
for RTM_O* and compat/sys/socket.h for SO_OTIMESTAMP to match struct
timeval50.

Roy