Re: miscfs/specfs/spec_vnops.c panic (triggered by filemon(4))

[Paul Goyette <paul%vps1.whooppee.com@localhost>]

On Tue, 5 Jan 2016, Taylor R Campbell wrote:

>   Date: Tue, 5 Jan 2016 09:39:15 +0800 (PHT)
>   From: Paul Goyette <paul%whooppee.com@localhost>
>
>   On Tue, 5 Jan 2016, Taylor R Campbell wrote:
>
>   > So I think DIAGNOSTIC condition is wrong.  I think the right condition
>   > is probably uio->uio_vmspace == vmspace_kernel().
>
>   Yes, this make a lot of sense.  I will fix it in both spec_write() and
>   in spec_read().
>
> I glanced at some other callers, and it looks like the usual idiom is
> VMSPACE_IS_KERNEL_P(uio->uio_vmspace).  (This actually checks whether
> the vmspace's vm_map's pmap is pmap_kernel(), although I'm not sure
> there are going to be any other vmspaces than vmspace_kernel() for
> which that is true.)

ACK - got it.  I'll be checking this in soon.

+------------------+--------------------------+------------------------+
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:      |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org |
+------------------+--------------------------+------------------------+