Re: Restructuring ARP cache

[christos%astron.com@localhost (Christos Zoulas)]

In article <CAKrYomjz7MjnyAp1xpQQ0z_GQ6i4kUxEbH_8hDq6FuTgdbfHag%mail.gmail.com@localhost>,
Ryota Ozaki  <ozaki-r%netbsd.org@localhost> wrote:
>On Mon, Aug 17, 2015 at 6:23 PM, Ryota Ozaki <ozaki-r%netbsd.org@localhost> wrote:
>> Hi,
>>
>> Here is a new patch that restructures ARP caches, which
>> aims for MP-safe network stack:
>> http://www.netbsd.org/~ozaki-r/lltable-arpcache.diff
>> (https://github.com/ozaki-r/netbsd-src/tree/lltable-arpcache)
>
>Updated the patch. The changes are:
>- Fix freeing mbuf in lltable_drain
>- Fix rtentry leak

It is hard to do a code review out of context:
- in_lltable_dump_entry wrong indent?
- use sizeof(*var) instead of sizeof(type)
- part of the code has return (foo) and other has return foo. Is that
  to keep the diffs with FreeBSD mimimal?
- foo() {
	if (....) {
		....
		....
	}
  }
  instead:
  foo() {
	if (!....)
		return;
	....
	....
  }
- why cast void *'s for example rif = (struct token_rif *)la->la_opaque;

christos