Re: [PATCH] Fixing soft NFS umount -f, round 4

[Emmanuel Dreyfus <manu%netbsd.org@localhost>]

On Wed, Jul 08, 2015 at 10:21:21AM -0700, Chuck Silvers wrote:
>  - in nfs_asyncio(), if an nfsiod has been assigned to the mount
>    but the request queue is long, we currently wait indefinitely
>    for the queue to drain a bit before enqueueing a new request.
>    your diff would change this so that if the queue does not drain
>    at all within 2 seconds, then the new request is failed.
>    that is much too aggressive, the timeout duration should be
>    more like the (timeout * retrans) formula that would apply
>    if the request were actually being processed.

I tried this change:
http://ftp.espci.fr/shadow/manu/umount_f4.patch

With default values, timeout = 3 and retrans = 10, we now wait
for ages or the unmount to completes. In the umount -f case
it does not makes sense to wait for too long.

-- 
Emmanuel Dreyfus
manu%netbsd.org@localhost