tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Brainy: R4 no error set in arm/xscale



Hi,
there's still one bug that hasn't been fixed in this report:

	http://m00nbsd.net/ae123a9bae03f7dde5c6d654412daf5a.html#Report-4

0x05 NO ERROR SET: sys/arch/arm/xscale/ixp425_if_npe.c [+] rev1.27
     No error set at l.610.

I would suggest this [1], but I can't test it. Can someone review it?

Thanks,
Maxime


[1]:

Index: ixp425_if_npe.c
===================================================================
RCS file: /cvsroot/src/sys/arch/arm/xscale/ixp425_if_npe.c,v
retrieving revision 1.28
diff -u -r1.28 ixp425_if_npe.c
--- ixp425_if_npe.c	13 Apr 2015 21:18:41 -0000	1.28
+++ ixp425_if_npe.c	20 Apr 2015 16:28:38 -0000
@@ -602,8 +602,9 @@
 		return error;
 	}
 
-	if (bus_dmamap_load(sc->sc_dt, sc->sc_stats_map, sc->sc_stats,
-	    sizeof(struct npestats), NULL, BUS_DMA_NOWAIT) != 0) {
+	error = bus_dmamap_load(sc->sc_dt, sc->sc_stats_map, sc->sc_stats,
+	    sizeof(struct npestats), NULL, BUS_DMA_NOWAIT);
+	if (error) {
 		aprint_error_dev(sc->sc_dev,
 		    "unable to %s for %s, error %u\n",
 		    "load map", "stats block", error);


Home | Main Index | Thread Index | Old Index