Re: FFS: ffs_is_appleufs()

[Maxime Villard <max%M00nBSD.net@localhost>]

Le 04/04/2015 16:07, Maxime Villard a écrit :
> Le 04/04/2015 15:42, Taylor R Campbell a écrit :
>>    Date: Sat, 04 Apr 2015 15:25:23 +0200
>>    From: Maxime Villard <max%M00nBSD.net@localhost>
>>
>>    here is a patch to put the AppleUFS detection code inside a function.
>>
>>    This changes the behavior a bit: if the kernel cannot determine whether the
>>    disk is an AppleUFS one or not, it now considers it as a normal UFS rather
>>    than returning an error and not mounting/reloading it.
>>
>>    Ok?
>>
>> Can you split that into two patches, one to factor out ffs_is_appleufs
>> with no functional change, and the other to change the behaviour?
>>
> 
> Hum, I doubt this is useful, since the goal of ffs_is_appleufs() is
> mainly to change the behavior.
> 
> The change is simple: now, errors occurring in _appleufs()'s bread
> just make ffs_is_appleufs return zero, to keep mounting the disk
> as a normal UFS..
> 

I'll commit this patch, unless anyone disagrees.