rwlock issue in secmodel

[Maxime Villard <max%M00nBSD.net@localhost>]

Hi,
I think there's a rwlock issue in secmodel/secmodel.c:

174	if (sm == NULL) {
175		error = EFAULT;
176		goto out;
177	}
178
179	/* Check if the secmodel is already present. */
180	rw_enter(&secmodels_lock, RW_WRITER);
...
 out:
194	/* Unlock the secmodels list. */
195	rw_exit(&secmodels_lock);
196
197	return error;

This goto out will release secmodels_lock while it is not yet held,
right?

The same in secmodel_unplug().