Re: Patch: xhci controller driver improvements

[Nick Hudson <skrll%netbsd.org@localhost>]

On 08/10/14 12:54, Takahiro HAYASHI wrote:
> Hi,
Hi,

> On 08/10/14 17:06, Nick Hudson wrote:
> > Some comments...


> > > @@ -2889,6 +3028,7 @@ xhci_timeout(void *addr)
> > >       struct xhci_softc * const sc = 
> > > xfer->pipe->device->bus->hci_private;
> > >       if (sc->sc_dying) {
> > > +        xhci_abort_xfer(xfer, USBD_TIMEOUT);
> > >           return;
> > >       }
> >
> > This looks very strange.
>
> Does it need sc_lock and unlock?
> or it's strange that xhci_abort_xfer is called
> from callout(softclock) interrupt context?

Calling xhci_abort_xfer while dying.

> > The driver makes far too much use of device_printf and all USB should 
> > move to KERNHIST.
>
> I didn't know about KERNHIST, thanks for notifying.
> I've replaced device_printf with DPRINTF or DPRINTFN in
> my local tree.
Please send diff :)

Nick