tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: wm_intr may lead wm_start unexpectedly



On Wed, Jun 25, 2014 at 06:51:06PM +0900, Ryota Ozaki wrote:
> >> Any comments?
> >
> > why not change in6_if_link_up() to use a delay >= 1 instead of 0 ?
> 
> My change intends to make it clear whether a callout will be used
> or not. I think it's error-prone.

for me, it's clear that a timeout of 0 means immediately, and so a
callout is not needed. I wouldn't expect a timeout of 0 to run through
a callout. I would also expect a negative timeout to either be EINVAL or
equivalent to 0.

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--


Home | Main Index | Thread Index | Old Index