Re: serious performance regression in .41

["J. Hannken-Illjes" <hannken%eis.cs.tu-bs.de@localhost>]

On 24 May 2014, at 19:32, Christos Zoulas <christos%astron.com@localhost> wrote:

> In article <69CE1CE4-6C54-4E17-802D-679A6A165F11%eis.cs.tu-bs.de@localhost>,
> J. Hannken-Illjes <hannken%eis.cs.tu-bs.de@localhost> wrote:
>> 
>> Ok, see me convinced.
> 
> Great :-)
> 
>> First, selector and context should be passed to vfs_vnode_iterator_init
>> as they are invariant.  We may (ab)use v_mount and v_data to avoid
>> allocating a state like we do with v_usecount now.
> 
> ok.

Why didn't you commit it then?

<snip>
> 
>> For ffs accessing the inode is safe (see ffs_reclaim).  I didn't check
>> the other uses though.
> 
> We should review all the selector calls. I don't think that calling
> VOP_GETATTR is ok. If it is not, why doesn't it KASSSET?

If you mean ffs_snapshot.c, here the file system is suspended so no
other thread may access the node(s).

--
J. Hannken-Illjes - hannken%eis.cs.tu-bs.de@localhost - TU Braunschweig 
(Germany)