tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: resource leak in linux emulation?



On Thu, 24 Apr 2014 07:18:10 David Laight wrote:
> > To fix, this should be added somewhere, probably at
> > sys/kern/kern_exit.c:487 (but I'm not sure if there's a better
> > location):
> >         if ((l->l_pflag & LP_PIDLID) != 0 && l->l_lid != p->p_pid) {
> >         
> >                 proc_free_pid(l->l_lid);
> >         
> >         }
> 
> That doesn't look like the right place.
> I think it should be further down (and with proc_lock held).

So can someone suggest where exactly the patch should go.  And isn't proc_lock 
held at this point (entered at line 344, exit at line 569)?

cheers
mark


Home | Main Index | Thread Index | Old Index