tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: suprious reboot on netbsd-6:i386 with PAE


Attached is a patch that seems to solve the problem at mine. Dovecot
works again and kdump does not dumps core anymore.

Your patch doesn't look right, and is probably incomplete, too.

For one thing, you append the trailing '\0' one byte beyond the
end of the the now extended mbuf.

In addition, there are other places where the additional byte
needs to be accounted for, e.g. in makeun() within this file.
Not sure whether there are others.

I am not sure I did the (nam->m_len > MLEN && !ext) case correctly, though.

I'd do the '\0'-terminating right after the memcpy.

And we now report the path length including the trailing zero, I do not
know if it is right or nor.

That's the whole purpose of this, isn't it? If you don't
include it in the mbuf length, it will not be copied out to
the user.

--                         Wolfgang Solfrank

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

Home | Main Index | Thread Index | Old Index