[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: trm(4) XS_RESET usage
On Sun, Nov 24, 2013 at 05:51:34PM +0100, Edgar Fuß wrote:
> While looking for examples of scsipi's XS_RESET usage, I stumbled over
> xs->error = XS_NOERROR | XS_RESET;
> in sys/dev/pci/trm.c.
> I don't think this does anything useful.
Yes, we want XS_RESET. This is harmless because XS_NOERROR is probably 0.
But as XS_* are enum values they're not intended to be used this way.
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
NetBSD: 26 ans d'experience feront toujours la difference
Main Index |
Thread Index |