Re: CVS commit: src/sys/lib/libunwind

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

joerg@ wrote:

> On Wed, Oct 16, 2013 at 11:36:18AM +0000, Martin Husemann wrote:
> > On Mon, Oct 14, 2013 at 01:14:58AM +0000, Joerg Sonnenberger wrote:
> > > Module Name:      src
> > > Committed By:     joerg
> > > Date:             Mon Oct 14 01:14:58 UTC 2013
> > > 
> > > Added Files:
> > >   src/sys/lib/libunwind: AddressSpace.hpp CREDITS.TXT
> > >       DwarfInstructions.hpp DwarfParser.hpp LICENSE.TXT Makefile.inc
> > >       Registers.hpp UnwindCursor.hpp dwarf2.h libunwind.cxx unwind.h
> > >       unwind_registers.S
> > > 
> > > Log Message:
> > > Add a heavily modified version of Apple's libunwind as released under
> > > MIT license in libc++abi. At the moment, only x86 support is tested.
> > 
> > A stealth import is no use in bypassing the standard questions:
> > 
> >  - where has this import been publically discussed?
> 
> The need was mentioned a number of times in various threads about libc++
> and clang.

Why do you always hide actual pointers (mailing list archive URLs etc.)
to the prior discussions you claim?  That's the reason why people think
and complain your commit is a stealth import.

Anyway, our commit guidelines explicitly require Core's approval
before adding a new package into base.  You violate the rule.
That's the enough reason to revert your commit without discussion.

--
Izumi Tsutsui