Re: x86/genfb_machdep.c multiplies width with stride

[Martin Husemann <martin%duskware.de@localhost>]

On Fri, Jun 28, 2013 at 04:05:55PM +0200, imre%vdsz.com@localhost wrote:
> In sys/arch/x86/x86/genfb_machdep.c at line 161, I found the following code:
> 
>       err = _x86_memio_map(t, (bus_addr_t)fbinfo->physaddr,
>           fbinfo->width * fbinfo->stride,
>           BUS_SPACE_MAP_LINEAR | BUS_SPACE_MAP_PREFETCHABLE, &h);
> 
> which looks to me like a typo, fbinfo->width should probably be replaced by
> fbinfo->height, to map exactly the visible portion of the framebuffer.

Good catch!

Michael, could you please reveiw & commit?

Thanks!

Martin