Re: [PATCH] POSIX extended API set 2

[manu%netbsd.org@localhost (Emmanuel Dreyfus)]

Taylor R Campbell <campbell+netbsd-tech-kern%mumble.net@localhost> wrote:

>    +  /*
>    +   * openat() falls back to open() behavior if
>    +   * - path is absolute XXX check this.
>    +   * - fd is AT_FDCWD
>    +   */
> 
> Have you checked the XXX, and/or written automatic tests for it?

In order to check for absolute path, I need to copyin the path, and it
wil be copied in later again. I suspect that check should go at namei
level.
  
> Also, `fd = fchmodat(...); close(fd)'?

Bad copy/paste, that you for pointing it out (and the inline also)

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu%netbsd.org@localhost